diff options
author | Eric Biggers <ebiggers@google.com> | 2023-10-27 13:30:17 -0700 |
---|---|---|
committer | Herbert Xu <herbert@gondor.apana.org.au> | 2023-11-01 12:58:42 +0800 |
commit | a312e07a65fb598ed239b940434392721385c722 (patch) | |
tree | 1626dbe670d719e911f330a16d06ca869aa2750c /security/keys | |
parent | b030c45844cfe0d4c89202cd6c9f4697b3a25a6a (diff) |
crypto: adiantum - flush destination page before unmapping
Upon additional review, the new fast path in adiantum_finish() is
missing the call to flush_dcache_page() that scatterwalk_map_and_copy()
was doing. It's apparently debatable whether flush_dcache_page() is
actually needed, as per the discussion at
https://lore.kernel.org/lkml/YYP1lAq46NWzhOf0@casper.infradead.org/T/#u.
However, it appears that currently all the helper functions that write
to a page, such as scatterwalk_map_and_copy(), memcpy_to_page(), and
memzero_page(), do the dcache flush. So do it to be consistent.
Fixes: dadf5e56c967 ("crypto: adiantum - add fast path for single-page messages")
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'security/keys')
0 files changed, 0 insertions, 0 deletions