diff options
author | John Stultz <jstultz@google.com> | 2024-04-09 13:22:12 -0700 |
---|---|---|
committer | Thomas Gleixner <tglx@linutronix.de> | 2024-04-10 22:07:42 +0200 |
commit | 076361362122a6d8a4c45f172ced5576b2d4a50d (patch) | |
tree | fe3a21d7c7ce89eb6bffe6e545a4fdd60c4d89b1 /io_uring/rsrc.h | |
parent | 5284984a4fbacb0883bfebe905902cdda2891a07 (diff) |
selftests: timers: Fix valid-adjtimex signed left-shift undefined behavior
The struct adjtimex freq field takes a signed value who's units are in
shifted (<<16) parts-per-million.
Unfortunately for negative adjustments, the straightforward use of:
freq = ppm << 16 trips undefined behavior warnings with clang:
valid-adjtimex.c:66:6: warning: shifting a negative signed value is undefined [-Wshift-negative-value]
-499<<16,
~~~~^
valid-adjtimex.c:67:6: warning: shifting a negative signed value is undefined [-Wshift-negative-value]
-450<<16,
~~~~^
..
Fix it by using a multiply by (1 << 16) instead of shifting negative values
in the valid-adjtimex test case. Align the values for better readability.
Reported-by: Lee Jones <joneslee@google.com>
Reported-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Signed-off-by: John Stultz <jstultz@google.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Link: https://lore.kernel.org/r/20240409202222.2830476-1-jstultz@google.com
Link: https://lore.kernel.org/lkml/0c6d4f0d-2064-4444-986b-1d1ed782135f@collabora.com/
Diffstat (limited to 'io_uring/rsrc.h')
0 files changed, 0 insertions, 0 deletions