diff options
| author | David Howells <dhowells@redhat.com> | 2024-09-23 16:07:50 +0100 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2024-09-27 18:29:20 +0200 |
| commit | ff98751bae40faed1ba9c6a7287e84430f7dec64 (patch) | |
| tree | e179353e9f6f04671a9dad6ef4ae4ec89427266b /fs/afs | |
| parent | 19dcfb9c1685d45ba96852e021415134865b0a95 (diff) | |
afs: Fix the setting of the server responding flag
In afs_wait_for_operation(), we set transcribe the call responded flag to
the server record that we used after doing the fileserver iteration loop -
but it's possible to exit the loop having had a response from the server
that we've discarded (e.g. it returned an abort or we started receiving
data, but the call didn't complete).
This means that op->server might be NULL, but we don't check that before
attempting to set the server flag.
Fixes: 98f9fda2057b ("afs: Fold the afs_addr_cursor struct in")
Signed-off-by: David Howells <dhowells@redhat.com>
Link: https://lore.kernel.org/r/20240923150756.902363-7-dhowells@redhat.com
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'fs/afs')
| -rw-r--r-- | fs/afs/fs_operation.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/afs/fs_operation.c b/fs/afs/fs_operation.c index 3546b087e791..428721bbe4f6 100644 --- a/fs/afs/fs_operation.c +++ b/fs/afs/fs_operation.c @@ -201,7 +201,7 @@ void afs_wait_for_operation(struct afs_operation *op) } } - if (op->call_responded) + if (op->call_responded && op->server) set_bit(AFS_SERVER_FL_RESPONDING, &op->server->flags); if (!afs_op_error(op)) { |