summaryrefslogtreecommitdiff
path: root/arch
diff options
context:
space:
mode:
authorDexuan Cui <decui@microsoft.com>2024-03-29 12:28:09 -0700
committerChristoph Hellwig <hch@lst.de>2024-04-02 17:08:09 +0200
commita1255ccab8ecee89905ddb12161139b0d878a7f2 (patch)
tree96303c8896872d3b3bb600b3774f7bcfba78f3e6 /arch
parente8068f2d756d57a5206fa3180ade365a8c12ed85 (diff)
swiotlb: do not set total_used to 0 in swiotlb_create_debugfs_files()
Sometimes the readout of /sys/kernel/debug/swiotlb/io_tlb_used and io_tlb_used_hiwater can be a huge number (e.g. 18446744073709551615), which is actually a negative number if we use "%ld" to print the number. When swiotlb_create_default_debugfs() is running from late_initcall, mem->total_used may already be non-zero, because the storage driver may have already started to perform I/O operations: if the storage driver is built-in, its probe() callback is called before late_initcall. swiotlb_create_debugfs_files() should not blindly set mem->total_used and mem->used_hiwater to 0; actually it doesn't have to initialize the fields at all, because the fields, as part of the global struct io_tlb_default_mem, have been implicitly initialized to zero. Also don't explicitly set mem->transient_nslabs to 0. Fixes: 8b0977ecc8b3 ("swiotlb: track and report io_tlb_used high water marks in debugfs") Fixes: 02e765697038 ("swiotlb: add debugfs to track swiotlb transient pool usage") Signed-off-by: Dexuan Cui <decui@microsoft.com> Reviewed-by: Michael Kelley <mhklinux@outlook.com> Reviewed-by: ZhangPeng <zhangpeng362@huawei.com> Reviewed-by: Petr Tesarik <petr.tesarik1@huawei-partners.com> Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'arch')
0 files changed, 0 insertions, 0 deletions