diff options
| author | Kemeng Shi <shikemeng@huaweicloud.com> | 2024-08-20 21:22:30 +0800 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2024-09-03 22:12:15 -0400 |
| commit | bb0a12c3439b10d88412fd3102df5b9a6e3cd6dc (patch) | |
| tree | f54c94fd3806c26b688e48c16f5e3829076b921c | |
| parent | 227d31b9214d1b9513383cf6c7180628d4b3b61f (diff) | |
ext4: avoid negative min_clusters in find_group_orlov()
min_clusters is signed integer and will be converted to unsigned
integer when compared with unsigned number stats.free_clusters.
If min_clusters is negative, it will be converted to a huge unsigned
value in which case all groups may not meet the actual desired free
clusters.
Set negative min_clusters to 0 to avoid unexpected behavior.
Fixes: ac27a0ec112a ("[PATCH] ext4: initial copy of files from ext3")
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Link: https://patch.msgid.link/20240820132234.2759926-4-shikemeng@huaweicloud.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
| -rw-r--r-- | fs/ext4/ialloc.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c index 9e2c08a8665f..81641be38c0e 100644 --- a/fs/ext4/ialloc.c +++ b/fs/ext4/ialloc.c @@ -514,6 +514,8 @@ static int find_group_orlov(struct super_block *sb, struct inode *parent, if (min_inodes < 1) min_inodes = 1; min_clusters = avefreec - EXT4_CLUSTERS_PER_GROUP(sb)*flex_size / 4; + if (min_clusters < 0) + min_clusters = 0; /* * Start looking in the flex group where we last allocated an |