diff options
| author | Chen Ni <nichen@iscas.ac.cn> | 2024-05-13 11:28:24 +0800 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2024-05-13 16:53:53 -0700 |
| commit | ad506586cb69292b6ac59ab95468aadd54b19ab7 (patch) | |
| tree | bd0914b4fc4f541c4fec8d3e7e98213a61afb802 | |
| parent | f440092bc5cae65982087417501febdcf5cd1d2b (diff) | |
dpll: fix return value check for kmemdup
The return value of kmemdup() is dst->freq_supported, not
src->freq_supported. Update the check accordingly.
Fixes: 830ead5fb0c5 ("dpll: fix pin dump crash for rebound module")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Reviewed-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Link: https://lore.kernel.org/r/20240513032824.2410459-1-nichen@iscas.ac.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | drivers/dpll/dpll_core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/dpll/dpll_core.c b/drivers/dpll/dpll_core.c index d0f6693ca142..32019dc33cca 100644 --- a/drivers/dpll/dpll_core.c +++ b/drivers/dpll/dpll_core.c @@ -449,7 +449,7 @@ static int dpll_pin_prop_dup(const struct dpll_pin_properties *src, sizeof(*src->freq_supported); dst->freq_supported = kmemdup(src->freq_supported, freq_size, GFP_KERNEL); - if (!src->freq_supported) + if (!dst->freq_supported) return -ENOMEM; } if (src->board_label) { |