diff options
| author | Marek Behún <kabel@kernel.org> | 2023-09-18 16:07:24 +0200 |
|---|---|---|
| committer | Lee Jones <lee@kernel.org> | 2023-09-19 15:16:23 +0100 |
| commit | 9dc1664fab2246bc2c3e9bf2cf21518a857f9b5b (patch) | |
| tree | fe5062d2f016900e7fd611bb6ab5098a86eb4ea5 | |
| parent | 0bb80ecc33a8fb5a682236443c1e740d5c917d1d (diff) | |
leds: Drop BUG_ON check for LED_COLOR_ID_MULTI
Commit c3f853184bed ("leds: Fix BUG_ON check for LED_COLOR_ID_MULTI that
is always false") fixed a no-op BUG_ON. This turned out to cause a
regression, since some in-tree device-tree files already use
LED_COLOR_ID_MULTI.
Drop the BUG_ON altogether.
Fixes: c3f853184bed ("leds: Fix BUG_ON check for LED_COLOR_ID_MULTI that is always false")
Reported-by: Da Xue <da@libre.computer>
Closes: https://lore.kernel.org/linux-leds/ZQLelWcNjjp2xndY@duo.ucw.cz/T/
Signed-off-by: Marek Behún <kabel@kernel.org>
Link: https://lore.kernel.org/r/20230918140724.18634-1-kabel@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org>
| -rw-r--r-- | drivers/leds/led-core.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c index 04f9ea675f2c..214ed81eb0e9 100644 --- a/drivers/leds/led-core.c +++ b/drivers/leds/led-core.c @@ -479,10 +479,6 @@ int led_compose_name(struct device *dev, struct led_init_data *init_data, led_parse_fwnode_props(dev, fwnode, &props); - /* We want to label LEDs that can produce full range of colors - * as RGB, not multicolor */ - BUG_ON(props.color == LED_COLOR_ID_MULTI); - if (props.label) { /* * If init_data.devicename is NULL, then it indicates that |