diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2024-04-03 10:06:33 +0200 |
|---|---|---|
| committer | Lee Jones <lee@kernel.org> | 2024-04-12 09:47:15 +0100 |
| commit | 4bea1ca9e366e1159047279b87334d5cf1bd3adf (patch) | |
| tree | 17bf10f16cdee278bc151fa466258eeb9dc3a887 | |
| parent | 1fe4f1bf60fdd2110480e8be8b084fcb2b1df656 (diff) | |
leds: apu: Remove duplicate DMI lookup data
Building with W=1 shows a warning about an unused dmi_system_id table:
drivers/leds/leds-apu.c:85:35: error: 'apu_led_dmi_table' defined but not used [-Werror=unused-const-variable=]
85 | static const struct dmi_system_id apu_led_dmi_table[] __initconst = {
Since the current version doesn't even do anything about the different
implementations but only checks the type of system, just drop the
custom lookup logic and call dmi_check_system() using the table itself.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20240403080702.3509288-16-arnd@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org>
| -rw-r--r-- | drivers/leds/leds-apu.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/leds/leds-apu.c b/drivers/leds/leds-apu.c index c409b80c236d..1c116aaa9b6e 100644 --- a/drivers/leds/leds-apu.c +++ b/drivers/leds/leds-apu.c @@ -181,8 +181,7 @@ static int __init apu_led_init(void) struct platform_device *pdev; int err; - if (!(dmi_match(DMI_SYS_VENDOR, "PC Engines") && - (dmi_match(DMI_PRODUCT_NAME, "APU") || dmi_match(DMI_PRODUCT_NAME, "apu1")))) { + if (!dmi_check_system(apu_led_dmi_table)) { pr_err("No PC Engines APUv1 board detected. For APUv2,3 support, enable CONFIG_PCENGINES_APU2\n"); return -ENODEV; } |