summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAbdel Alkuor <alkuor@gmail.com>2024-03-05 08:38:17 -0500
committerLee Jones <lee@kernel.org>2024-03-07 08:48:20 +0000
commit45066c4bbe8ca25f9f282245b84568116c783f1d (patch)
treef2d4d032c4c6811c32e555c1f36ce4b6c10896b1
parent7b7e50f8f5e0b12ebd6cc7076602eca7256de118 (diff)
leds: ncp5623: Add MS suffix to time defines
To make the time macro defines clearer, add MS as a suffix. Signed-off-by: Abdel Alkuor <alkuor@gmail.com> Link: https://lore.kernel.org/r/20240305133824.1551809-1-alkuor@gmail.com Signed-off-by: Lee Jones <lee@kernel.org>
-rw-r--r--drivers/leds/rgb/leds-ncp5623.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/leds/rgb/leds-ncp5623.c b/drivers/leds/rgb/leds-ncp5623.c
index b669c55c5483..2be4ff918516 100644
--- a/drivers/leds/rgb/leds-ncp5623.c
+++ b/drivers/leds/rgb/leds-ncp5623.c
@@ -22,8 +22,8 @@
#define NCP5623_DIMMING_TIME_REG NCP5623_REG(0x7)
#define NCP5623_MAX_BRIGHTNESS 0x1f
-#define NCP5623_MAX_DIM_TIME 240 /* ms */
-#define NCP5623_DIM_STEP 8 /* ms */
+#define NCP5623_MAX_DIM_TIME_MS 240
+#define NCP5623_DIM_STEP_MS 8
struct ncp5623 {
struct i2c_client *client;
@@ -92,8 +92,8 @@ static int ncp5623_pattern_set(struct led_classdev *cdev,
ncp->delay = 0;
- if (pattern[0].delta_t > NCP5623_MAX_DIM_TIME ||
- (pattern[0].delta_t % NCP5623_DIM_STEP) != 0)
+ if (pattern[0].delta_t > NCP5623_MAX_DIM_TIME_MS ||
+ (pattern[0].delta_t % NCP5623_DIM_STEP_MS) != 0)
return -EINVAL;
brightness_diff = pattern[0].brightness - ncp->current_brightness;
@@ -117,7 +117,7 @@ static int ncp5623_pattern_set(struct led_classdev *cdev,
ret = ncp5623_write(ncp->client,
NCP5623_DIMMING_TIME_REG,
- pattern[0].delta_t / NCP5623_DIM_STEP);
+ pattern[0].delta_t / NCP5623_DIM_STEP_MS);
if (ret)
return ret;