diff options
| author | Andy Shevchenko <andy.shevchenko@gmail.com> | 2024-03-27 23:52:08 +0200 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2024-04-08 15:22:23 +0200 |
| commit | 1d86d946d3413436edcce7fd22d803af9c5b39e8 (patch) | |
| tree | 6ebc389b661d040978a3636252cccba2b3cf1b61 | |
| parent | 609bf4bd8e597f3eca631a6382f59331972905e0 (diff) | |
platform/x86: quickstart: Miscellaneous improvements
There is a mix of a few improvements to the driver.
I have done this instead of review, so it can quickly be
folded into the original code (partially or fully).
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: Armin Wolf <W_Armin@gmx.de>
Link: https://lore.kernel.org/r/20240327215208.649020-1-andy.shevchenko@gmail.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
| -rw-r--r-- | drivers/platform/x86/quickstart.c | 16 |
1 files changed, 10 insertions, 6 deletions
diff --git a/drivers/platform/x86/quickstart.c b/drivers/platform/x86/quickstart.c index ba3a7a25dda7..f686942662cc 100644 --- a/drivers/platform/x86/quickstart.c +++ b/drivers/platform/x86/quickstart.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0-or-later /* - * quickstart.c - ACPI Direct App Launch driver + * ACPI Direct App Launch driver * * Copyright (C) 2024 Armin Wolf <W_Armin@gmx.de> * Copyright (C) 2022 Arvid Norlander <lkml@vorapal.se> @@ -10,15 +10,18 @@ * <https://archive.org/details/microsoft-acpi-dirapplaunch> */ -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt - #include <linux/acpi.h> +#include <linux/device.h> +#include <linux/errno.h> #include <linux/init.h> #include <linux/input.h> #include <linux/input/sparse-keymap.h> -#include <linux/kernel.h> +#include <linux/mod_devicetable.h> #include <linux/module.h> #include <linux/platform_device.h> +#include <linux/pm_wakeup.h> +#include <linux/printk.h> +#include <linux/slab.h> #include <linux/sysfs.h> #include <linux/types.h> @@ -165,7 +168,8 @@ static int quickstart_probe(struct platform_device *pdev) data->dev = &pdev->dev; dev_set_drvdata(&pdev->dev, data); - /* We have to initialize the device wakeup before evaluating GHID because + /* + * We have to initialize the device wakeup before evaluating GHID because * doing so will notify the device if the button was used to wake the machine * from S5. */ @@ -202,7 +206,7 @@ static int quickstart_probe(struct platform_device *pdev) } static const struct acpi_device_id quickstart_device_ids[] = { - { "PNP0C32", 0 }, + { "PNP0C32" }, { } }; MODULE_DEVICE_TABLE(acpi, quickstart_device_ids); |