summaryrefslogtreecommitdiff
path: root/virt
diff options
context:
space:
mode:
authorBrian Norris <briannorris@chromium.org>2019-06-14 17:13:20 -0700
committerKalle Valo <kvalo@codeaurora.org>2019-06-24 16:22:50 +0300
commit63d7ef36103d26f20325a921ecc96a3288560146 (patch)
treed75e9b8d6adee2d5596a97be1bdc7feb5c69f0f4 /virt
parent608fd7214323bd3bb2c288f68253e5bb634d4f49 (diff)
mwifiex: Don't abort on small, spec-compliant vendor IEs
Per the 802.11 specification, vendor IEs are (at minimum) only required to contain an OUI. A type field is also included in ieee80211.h (struct ieee80211_vendor_ie) but doesn't appear in the specification. The remaining fields (subtype, version) are a convention used in WMM headers. Thus, we should not reject vendor-specific IEs that have only the minimum length (3 bytes) -- we should skip over them (since we only want to match longer IEs, that match either WMM or WPA formats). We can reject elements that don't have the minimum-required 3 byte OUI. While we're at it, move the non-standard subtype and version fields into the WMM structs, to avoid this confusion in the future about generic "vendor header" attributes. Fixes: 685c9b7750bf ("mwifiex: Abort at too short BSS descriptor element") Cc: Takashi Iwai <tiwai@suse.de> Signed-off-by: Brian Norris <briannorris@chromium.org> Reviewed-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Diffstat (limited to 'virt')
0 files changed, 0 insertions, 0 deletions