summaryrefslogtreecommitdiff
path: root/rust
diff options
context:
space:
mode:
authorAndreas Hindborg <a.hindborg@samsung.com>2024-06-15 01:53:50 +0200
committerJens Axboe <axboe@kernel.dk>2024-06-14 18:25:13 -0600
commit5e3b7009f116f684ac6b93d8924506154f3b1f6d (patch)
tree6bec856d0aaa1deb95657471a8dd595978dd1ecd /rust
parente3e72fe4cb1d1b7399fab0e98166b8bfcddb9ec7 (diff)
rust: block: do not use removed queue limit API
The Rust block layer API was using the old queue limit API, which was just removed. Use the new API instead. Reported-by: Boqun Feng <boqun.feng@gmail.com> Fixes: 3253aba3408a ("rust: block: introduce `kernel::block::mq` module") Signed-off-by: Andreas Hindborg <a.hindborg@samsung.com> Link: https://lore.kernel.org/r/20240614235350.621121-1-nmi@metaspace.dk Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'rust')
-rw-r--r--rust/kernel/block/mq/gen_disk.rs20
1 files changed, 7 insertions, 13 deletions
diff --git a/rust/kernel/block/mq/gen_disk.rs b/rust/kernel/block/mq/gen_disk.rs
index 3b9edb96c8ff..e06044b549e0 100644
--- a/rust/kernel/block/mq/gen_disk.rs
+++ b/rust/kernel/block/mq/gen_disk.rs
@@ -95,11 +95,17 @@ impl GenDiskBuilder {
) -> Result<GenDisk<T>> {
let lock_class_key = crate::sync::LockClassKey::new();
+ // SAFETY: `bindings::queue_limits` contain only fields that are valid when zeroed.
+ let mut lim: bindings::queue_limits = unsafe { core::mem::zeroed() };
+
+ lim.logical_block_size = self.logical_block_size;
+ lim.physical_block_size = self.physical_block_size;
+
// SAFETY: `tagset.raw_tag_set()` points to a valid and initialized tag set
let gendisk = from_err_ptr(unsafe {
bindings::__blk_mq_alloc_disk(
tagset.raw_tag_set(),
- core::ptr::null_mut(), // TODO: We can pass queue limits right here
+ &mut lim,
core::ptr::null_mut(),
lock_class_key.as_ptr(),
)
@@ -142,18 +148,6 @@ impl GenDiskBuilder {
raw_writer.write_char('\0')?;
// SAFETY: `gendisk` points to a valid and initialized instance of
- // `struct gendisk`. We have exclusive access, so we cannot race.
- unsafe {
- bindings::blk_queue_logical_block_size((*gendisk).queue, self.logical_block_size)
- };
-
- // SAFETY: `gendisk` points to a valid and initialized instance of
- // `struct gendisk`. We have exclusive access, so we cannot race.
- unsafe {
- bindings::blk_queue_physical_block_size((*gendisk).queue, self.physical_block_size)
- };
-
- // SAFETY: `gendisk` points to a valid and initialized instance of
// `struct gendisk`. `set_capacity` takes a lock to synchronize this
// operation, so we will not race.
unsafe { bindings::set_capacity(gendisk, self.capacity_sectors) };