summaryrefslogtreecommitdiff
path: root/net
diff options
context:
space:
mode:
authorDaniel Starke <daniel.starke@siemens.com>2023-10-26 07:58:43 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-10-26 10:35:08 +0200
commit3a75b205de43365f80a33b98ec9289785da56243 (patch)
tree7dcba7e971eff9cc19ce44afe517665fcd7336a2 /net
parent6f699743aebf07538e506a46c5965eb8bdd2c716 (diff)
tty: n_gsm: fix race condition in status line change on dead connections
gsm_cleanup_mux() cleans up the gsm by closing all DLCIs, stopping all timers, removing the virtual tty devices and clearing the data queues. This procedure, however, may cause subsequent changes of the virtual modem status lines of a DLCI. More data is being added the outgoing data queue and the deleted kick timer is restarted to handle this. At this point many resources have already been removed by the cleanup procedure. Thus, a kernel panic occurs. Fix this by proving in gsm_modem_update() that the cleanup procedure has not been started and the mux is still alive. Note that writing to a virtual tty is already protected by checks against the DLCI specific connection state. Fixes: c568f7086c6e ("tty: n_gsm: fix missing timer to handle stalled links") Cc: stable <stable@kernel.org> Signed-off-by: Daniel Starke <daniel.starke@siemens.com> Link: https://lore.kernel.org/r/20231026055844.3127-1-daniel.starke@siemens.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions