diff options
author | Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com> | 2020-08-07 16:59:02 +0530 |
---|---|---|
committer | Wim Van Sebroeck <wim@linux-watchdog.org> | 2020-10-14 15:02:21 +0200 |
commit | 4b2e7f99cdd314263c9d172bc17193b8b6bba463 (patch) | |
tree | e6c4a60c323581fa36a9a68cee62ef2ebf1b93e7 /kernel/panic.c | |
parent | a1b8638ba1320e6684aa98233c15255eb803fac7 (diff) |
drivers: watchdog: rdc321x_wdt: Fix race condition bugs
In rdc321x_wdt_probe(), rdc321x_wdt_device.queue is initialized
after misc_register(), hence if ioctl is called before its
initialization which can call rdc321x_wdt_start() function,
it will see an uninitialized value of rdc321x_wdt_device.queue,
hence initialize it before misc_register().
Also, rdc321x_wdt_device.default_ticks is accessed in reset()
function called from write callback, thus initialize it before
misc_register().
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20200807112902.28764-1-madhuparnabhowmik10@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
Diffstat (limited to 'kernel/panic.c')
0 files changed, 0 insertions, 0 deletions