summaryrefslogtreecommitdiff
path: root/include/linux/klist.h
diff options
context:
space:
mode:
authorTejun Heo <tj@kernel.org>2024-06-25 15:29:58 -1000
committerPeter Zijlstra <peterz@infradead.org>2024-07-04 15:59:52 +0200
commitd329605287020c3d1c3b0dadc63d8208e7251382 (patch)
tree8e96bade108c8790c2f317621c616c085ad62c83 /include/linux/klist.h
parent0ec208ce9834929769ace0e2a506106192d08069 (diff)
sched/fair: set_load_weight() must also call reweight_task() for SCHED_IDLE tasks
When a task's weight is being changed, set_load_weight() is called with @update_load set. As weight changes aren't trivial for the fair class, set_load_weight() calls fair.c::reweight_task() for fair class tasks. However, set_load_weight() first tests task_has_idle_policy() on entry and skips calling reweight_task() for SCHED_IDLE tasks. This is buggy as SCHED_IDLE tasks are just fair tasks with a very low weight and they would incorrectly skip load, vlag and position updates. Fix it by updating reweight_task() to take struct load_weight as idle weight can't be expressed with prio and making set_load_weight() call reweight_task() for SCHED_IDLE tasks too when @update_load is set. Fixes: 9059393e4ec1 ("sched/fair: Use reweight_entity() for set_user_nice()") Suggested-by: Peter Zijlstra (Intel) <peterz@infradead.org> Signed-off-by: Tejun Heo <tj@kernel.org> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Cc: stable@vger.kernel.org # v4.15+ Link: http://lkml.kernel.org/r/20240624102331.GI31592@noisy.programming.kicks-ass.net
Diffstat (limited to 'include/linux/klist.h')
0 files changed, 0 insertions, 0 deletions