diff options
| author | Paulo Alcantara <pc@manguebit.com> | 2023-10-30 17:19:53 -0300 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2023-11-02 08:05:45 -0500 |
| commit | c37ed2d7d09869f30d291b9c6cba56ea4f0b0417 (patch) | |
| tree | cfd266f589f9d30f18e5f54e70dd9bcd204477db /fs/smb | |
| parent | 4cf6e1101a25ca5e63d48adf49b0a8a64bae790f (diff) | |
smb: client: remove extra @chan_count check in __cifs_put_smb_ses()
If @ses->chan_count <= 1, then for-loop body will not be executed so
no need to check it twice.
Reviewed-by: Shyam Prasad N <sprasad@microsoft.com>
Signed-off-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs/smb')
| -rw-r--r-- | fs/smb/client/connect.c | 23 |
1 files changed, 9 insertions, 14 deletions
diff --git a/fs/smb/client/connect.c b/fs/smb/client/connect.c index 15a1c86482ed..4974507ca217 100644 --- a/fs/smb/client/connect.c +++ b/fs/smb/client/connect.c @@ -1973,9 +1973,10 @@ cifs_find_smb_ses(struct TCP_Server_Info *server, struct smb3_fs_context *ctx) void __cifs_put_smb_ses(struct cifs_ses *ses) { - unsigned int rc, xid; - unsigned int chan_count; struct TCP_Server_Info *server = ses->server; + unsigned int xid; + size_t i; + int rc; spin_lock(&ses->ses_lock); if (ses->ses_status == SES_EXITING) { @@ -2021,20 +2022,14 @@ void __cifs_put_smb_ses(struct cifs_ses *ses) list_del_init(&ses->smb_ses_list); spin_unlock(&cifs_tcp_ses_lock); - chan_count = ses->chan_count; - /* close any extra channels */ - if (chan_count > 1) { - int i; - - for (i = 1; i < chan_count; i++) { - if (ses->chans[i].iface) { - kref_put(&ses->chans[i].iface->refcount, release_iface); - ses->chans[i].iface = NULL; - } - cifs_put_tcp_session(ses->chans[i].server, 0); - ses->chans[i].server = NULL; + for (i = 1; i < ses->chan_count; i++) { + if (ses->chans[i].iface) { + kref_put(&ses->chans[i].iface->refcount, release_iface); + ses->chans[i].iface = NULL; } + cifs_put_tcp_session(ses->chans[i].server, 0); + ses->chans[i].server = NULL; } sesInfoFree(ses); |