diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2024-01-05 16:47:54 +0300 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2024-01-22 11:37:27 +0100 |
| commit | 8446f9d11678bc268897882e86733d73204f83c4 (patch) | |
| tree | 5e2f0253e8bc8a88a6341441a9058867a6a73090 /drivers | |
| parent | 29e473f4b51ee56b5808323e274a8369b4d181cb (diff) | |
platform/x86: wmi: Fix wmi_dev_probe()
This has a reversed if statement so it accidentally disables the wmi
method before returning.
Fixes: 704af3a40747 ("platform/x86: wmi: Remove chardev interface")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Armin Wolf <W_Armin@gmx.de>
Link: https://lore.kernel.org/r/9c81251b-bc87-4ca3-bb86-843dc85e5145@moroto.mountain
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/platform/x86/wmi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c index d1df1a31de00..3c288e8f404b 100644 --- a/drivers/platform/x86/wmi.c +++ b/drivers/platform/x86/wmi.c @@ -896,7 +896,7 @@ static int wmi_dev_probe(struct device *dev) if (wdriver->probe) { ret = wdriver->probe(dev_to_wdev(dev), find_guid_context(wblock, wdriver)); - if (!ret) { + if (ret) { if (ACPI_FAILURE(wmi_method_enable(wblock, false))) dev_warn(dev, "Failed to disable device\n"); |