diff options
author | Len Baker <len.baker@gmx.com> | 2021-09-12 15:10:57 +0200 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2021-09-13 13:02:38 +0100 |
commit | 9eb4c320be9c1b357dbc905c7e60dfffa8c854b9 (patch) | |
tree | 7fc78fc69be404f21b79a285956bf54351ab6313 /drivers/target | |
parent | f55e36d5ab76c3097ff36ecea60b91c6b0d80fc8 (diff) |
nfp: Prefer struct_size over open coded arithmetic
As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.
So, use the struct_size() helper to do the arithmetic instead of the
argument "size + count * size" in the kzalloc() function.
[1] https://www.kernel.org/doc/html/v5.14/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments
Signed-off-by: Len Baker <len.baker@gmx.com>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/target')
0 files changed, 0 insertions, 0 deletions