diff options
| author | Dinghao Liu <dinghao.liu@zju.edu.cn> | 2021-03-01 20:50:57 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-03-10 09:21:02 +0100 |
| commit | f8096ff38d5f62d8a2c473e1bec0163a1b2b86d8 (patch) | |
| tree | 1c0b9215225f6f4508496090a32b8cef821f446a /drivers/misc/ad525x_dpot.c | |
| parent | bc6350167ef4e003e463c25417b48a446e48001d (diff) | |
drivers: misc: ad525x_dpot: Add missing check in dpot_read_spi
The use of dpot_read_r8d8() after checking dpot->uid is similar.
However, we check the return value and return an error code only
in one path, which is odd.
Link: https://lore.kernel.org/r/20210301125057.28819-1-dinghao.liu@zju.edu.cn
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc/ad525x_dpot.c')
| -rw-r--r-- | drivers/misc/ad525x_dpot.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/misc/ad525x_dpot.c b/drivers/misc/ad525x_dpot.c index 6f164522b028..5d8f3f6a95f2 100644 --- a/drivers/misc/ad525x_dpot.c +++ b/drivers/misc/ad525x_dpot.c @@ -139,6 +139,9 @@ static s32 dpot_read_spi(struct dpot_data *dpot, u8 reg) value = dpot_read_r8d8(dpot, DPOT_AD5291_READ_RDAC << 2); + if (value < 0) + return value; + if (dpot->uid == DPOT_UID(AD5291_ID)) value = value >> 2; |