diff options
author | Alejandro Lucero <alejandro.lucero-palau@amd.com> | 2022-07-26 08:45:04 +0200 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2022-07-27 18:20:43 -0700 |
commit | 67c3b611d92fc238c43734878bc3e232ab570c79 (patch) | |
tree | 6bd0db5ae924e9a78c7b184fd830f431c60437f0 /drivers/ipack | |
parent | 0c104556267242d922a3def60be8092b280e4fee (diff) |
sfc: disable softirqs for ptp TX
Sending a PTP packet can imply to use the normal TX driver datapath but
invoked from the driver's ptp worker. The kernel generic TX code
disables softirqs and preemption before calling specific driver TX code,
but the ptp worker does not. Although current ptp driver functionality
does not require it, there are several reasons for doing so:
1) The invoked code is always executed with softirqs disabled for non
PTP packets.
2) Better if a ptp packet transmission is not interrupted by softirq
handling which could lead to high latencies.
3) netdev_xmit_more used by the TX code requires preemption to be
disabled.
Indeed a solution for dealing with kernel preemption state based on static
kernel configuration is not possible since the introduction of dynamic
preemption level configuration at boot time using the static calls
functionality.
Fixes: f79c957a0b537 ("drivers: net: sfc: use netdev_xmit_more helper")
Signed-off-by: Alejandro Lucero <alejandro.lucero-palau@amd.com>
Link: https://lore.kernel.org/r/20220726064504.49613-1-alejandro.lucero-palau@amd.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/ipack')
0 files changed, 0 insertions, 0 deletions