diff options
| author | Wei Yongjun <weiyongjun1@huawei.com> | 2018-01-18 01:43:19 +0000 |
|---|---|---|
| committer | Corey Minyard <cminyard@mvista.com> | 2018-01-22 08:10:37 -0600 |
| commit | e749d328b0b450aa78d562fa26a0cd8872325dd9 (patch) | |
| tree | cf4f013e3a78e21e79b39636884fed955c8c057b /drivers/char/ipmi/ipmi_powernv.c | |
| parent | 5516e21a1e95e9b9f39985598431a25477d91643 (diff) | |
ipmi/powernv: Fix error return code in ipmi_powernv_probe()
Fix to return a negative error code from the request_irq() error
handling case instead of 0, as done elsewhere in this function.
Fixes: dce143c3381c ("ipmi/powernv: Convert to irq event interface")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Diffstat (limited to 'drivers/char/ipmi/ipmi_powernv.c')
| -rw-r--r-- | drivers/char/ipmi/ipmi_powernv.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/char/ipmi/ipmi_powernv.c b/drivers/char/ipmi/ipmi_powernv.c index c687c8d57c92..bcf493d8e238 100644 --- a/drivers/char/ipmi/ipmi_powernv.c +++ b/drivers/char/ipmi/ipmi_powernv.c @@ -250,8 +250,9 @@ static int ipmi_powernv_probe(struct platform_device *pdev) ipmi->irq = opal_event_request(prop); } - if (request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH, - "opal-ipmi", ipmi)) { + rc = request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH, + "opal-ipmi", ipmi); + if (rc) { dev_warn(dev, "Unable to request irq\n"); goto err_dispose; } |