diff options
author | Martin K. Petersen <martin.petersen@oracle.com> | 2024-04-05 21:07:23 -0400 |
---|---|---|
committer | Martin K. Petersen <martin.petersen@oracle.com> | 2024-04-05 21:07:23 -0400 |
commit | 0e0a4da35284c85225e3b128912582ebc73256c8 (patch) | |
tree | f65d0272efaa5bbb2c3121a967629953eefca635 /crypto/lrw.c | |
parent | 9282899e1e7e245c464f5996119fb06d48b97d4a (diff) | |
parent | 356a8ce7cd5037fa0863c2ac83a35c8ebf6e0e02 (diff) |
Merge patch series "scsi: ufs: Remove overzealous memory barriers"
Andrew Halaney <ahalaney@redhat.com> says:
Please review with care as I'm not all that confident in this subject.
UFS has a lot of mb() variants used, most with comments saying "ensure
this takes effect before continuing". mb()'s aren't really the way to
guarantee that, a read back is the best method.
Some of these though I think could go a step further and remove the
mb() variant without a read back. As far as I can tell there's no real
reason to ensure it takes effect in most cases (there's no delay() or
anything afterwards, and eventually another readl()/writel() happens
which is by definition ordered). Some of the patches in this series do
that if I was confident it was safe (or a reviewer pointed out prior
that they thought it was safe to do so).
Thanks in advance for the help,
Andrew
Link: https://lore.kernel.org/r/20240329-ufs-reset-ensure-effect-before-delay-v5-0-181252004586@redhat.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'crypto/lrw.c')
0 files changed, 0 insertions, 0 deletions