diff options
author | Heiner Kallweit <hkallweit1@gmail.com> | 2023-11-26 23:01:02 +0100 |
---|---|---|
committer | Paolo Abeni <pabeni@redhat.com> | 2023-11-28 12:52:49 +0100 |
commit | 91d3d149978ba7b238198dd80e4b823756aa7cfa (patch) | |
tree | bc2da08204dfc79dda997764d247d7dd12654190 /CREDITS | |
parent | 59d395ed606d8df14615712b0cdcdadb2d962175 (diff) |
r8169: prevent potential deadlock in rtl8169_close
ndo_stop() is RTNL-protected by net core, and the worker function takes
RTNL as well. Therefore we will deadlock when trying to execute a
pending work synchronously. To fix this execute any pending work
asynchronously. This will do no harm because netif_running() is false
in ndo_stop(), and therefore the work function is effectively a no-op.
However we have to ensure that no task is running or pending after
rtl_remove_one(), therefore add a call to cancel_work_sync().
Fixes: abe5fc42f9ce ("r8169: use RTNL to protect critical sections")
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://lore.kernel.org/r/12395867-1d17-4cac-aa7d-c691938fcddf@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'CREDITS')
0 files changed, 0 insertions, 0 deletions