diff options
| author | Lee Jones <lee.jones@linaro.org> | 2020-06-23 11:05:23 +0100 |
|---|---|---|
| committer | Lee Jones <lee.jones@linaro.org> | 2020-07-06 08:31:55 +0100 |
| commit | ddb6b26c4102aab886277b2ca3c027b4976d819b (patch) | |
| tree | 5faa77d90f7b5c59be21913fdc6f13d5e7187f77 | |
| parent | 54daa5d47c47662067115a78dd317fba3de9e828 (diff) | |
mfd: ab8500-debugfs: Fix incompatible types in comparison expression issue
Smatch reports:
drivers/mfd/ab8500-debugfs.c:1804:20: error: incompatible types in comparison expression (different type sizes):
drivers/mfd/ab8500-debugfs.c:1804:20: unsigned int *
drivers/mfd/ab8500-debugfs.c:1804:20: unsigned long *
This is due to mixed types being compared in a min() comparison. Fix
this by treating values as signed and casting them to the same type
as the receiving variable.
Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
| -rw-r--r-- | drivers/mfd/ab8500-debugfs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c index 1a9a3414d4fa..6d1bf7c3ca3b 100644 --- a/drivers/mfd/ab8500-debugfs.c +++ b/drivers/mfd/ab8500-debugfs.c @@ -1801,7 +1801,7 @@ static ssize_t ab8500_hwreg_write(struct file *file, int buf_size, ret; /* Get userspace string and assure termination */ - buf_size = min(count, (sizeof(buf)-1)); + buf_size = min((int)count, (int)(sizeof(buf)-1)); if (copy_from_user(buf, user_buf, buf_size)) return -EFAULT; buf[buf_size] = 0; |