diff options
| author | Brian Norris <computersforpeace@gmail.com> | 2016-03-07 15:52:05 -0800 |
|---|---|---|
| committer | Brian Norris <computersforpeace@gmail.com> | 2016-07-09 18:48:53 -0700 |
| commit | b137aab438382fdadfe1272869357485af0252b4 (patch) | |
| tree | aca0d7028b98bbbc2c00aa694b9034141af3aa56 | |
| parent | c3cb77f8980db9dba614822d2d4a4cc61e44c8e2 (diff) | |
mtd: physmap_of: fix set but unused warning
drivers/mtd/maps/physmap_of.c: In function ‘of_flash_probe’:
drivers/mtd/maps/physmap_of.c:165:16: warning: variable ‘p’ set but not used [-Wunused-but-set-variable]
This could be a problem if the 'reg' property is not set, since that
means 'count' will be uninitialized.
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
| -rw-r--r-- | drivers/mtd/maps/physmap_of.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mtd/maps/physmap_of.c b/drivers/mtd/maps/physmap_of.c index 22f3858c0364..3fad35942895 100644 --- a/drivers/mtd/maps/physmap_of.c +++ b/drivers/mtd/maps/physmap_of.c @@ -186,7 +186,7 @@ static int of_flash_probe(struct platform_device *dev) * consists internally of 2 non-identical NOR chips on one die. */ p = of_get_property(dp, "reg", &count); - if (count % reg_tuple_size != 0) { + if (!p || count % reg_tuple_size != 0) { dev_err(&dev->dev, "Malformed reg property on %s\n", dev->dev.of_node->full_name); err = -EINVAL; |