summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorXu Panda <xu.panda@zte.com.cn>2022-12-23 10:39:12 +0800
committerRob Herring <robh@kernel.org>2023-01-05 21:23:14 -0600
commita98bf9df1c332a2c447083e1a2ca9578cd9f0721 (patch)
treea65cbcdda0c8b69b3e883a1e2489bdddcbeddb9e
parent00f2a08cd785d262c760282ec027caa6ea8975d4 (diff)
of: base: use strscpy() to instead of strncpy()
The implementation of strscpy() is more robust and safer. That's now the recommended way to copy NUL terminated strings. Signed-off-by: Xu Panda <xu.panda@zte.com.cn> Signed-off-by: Yang Yang <yang.yang29@zte.com> Link: https://lore.kernel.org/r/202212231039128402297@zte.com.cn Signed-off-by: Rob Herring <robh@kernel.org>
-rw-r--r--drivers/of/base.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/of/base.c b/drivers/of/base.c
index d5a5c35eba72..ac6fde53342f 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1884,8 +1884,7 @@ static void of_alias_add(struct alias_prop *ap, struct device_node *np,
{
ap->np = np;
ap->id = id;
- strncpy(ap->stem, stem, stem_len);
- ap->stem[stem_len] = 0;
+ strscpy(ap->stem, stem, stem_len + 1);
list_add_tail(&ap->link, &aliases_lookup);
pr_debug("adding DT alias:%s: stem=%s id=%i node=%pOF\n",
ap->alias, ap->stem, ap->id, np);