diff options
| author | Nishka Dasgupta <nishkadg.linux@gmail.com> | 2019-07-24 14:02:31 +0530 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2019-08-01 14:07:46 +0100 |
| commit | 811ba489fa524ec634933cdf83aaf6c007a4c004 (patch) | |
| tree | c19e850c2a528088b12afc868ac21f8d5d25bd5c | |
| parent | a853c0a0b013af3fee0f028cff3c44e275ce9abd (diff) | |
regulator: of: Add of_node_put() before return in function
The local variable search in regulator_of_get_init_node takes the value
returned by either of_get_child_by_name or of_node_get, both of which
get a node. If this node is not put before returning, it could cause a
memory leak. Hence put search before a mid-loop return statement.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Link: https://lore.kernel.org/r/20190724083231.10276-1-nishkadg.linux@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/regulator/of_regulator.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c index 397918ebba55..9112faa6a9a0 100644 --- a/drivers/regulator/of_regulator.c +++ b/drivers/regulator/of_regulator.c @@ -416,8 +416,10 @@ device_node *regulator_of_get_init_node(struct device *dev, if (!name) name = child->name; - if (!strcmp(desc->of_match, name)) + if (!strcmp(desc->of_match, name)) { + of_node_put(search); return of_node_get(child); + } } of_node_put(search); |