diff options
| author | Tiezhu Yang <yangtiezhu@loongson.cn> | 2020-02-13 12:16:07 +0800 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2020-02-13 13:17:39 +0000 |
| commit | 470a072e12200576788dc622d58894609feae2d7 (patch) | |
| tree | fdf990e9665f3f1dbc29fcf73140ad8b5b08e0ed | |
| parent | 1f3c36328a487059beebd1f7be042e3b7abf7d34 (diff) | |
spi: spidev_test: Use perror() only if errno is not 0
It is better to use perror() only if errno is not 0, it should use printf()
when errno is 0, otherwise there exists redudant ": Success".
E.g. without this patch:
$ ./spidev_test -p 1234 --input test.bin
only one of -p and --input may be selected: Success
Aborted (core dumped)
With this patch:
$ ./spidev_test -p 1234 --input test.bin
only one of -p and --input may be selected
Aborted (core dumped)
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/1581567368-8055-3-git-send-email-yangtiezhu@loongson.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | tools/spi/spidev_test.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/tools/spi/spidev_test.c b/tools/spi/spidev_test.c index 5866178cdcc9..27967dd90f8f 100644 --- a/tools/spi/spidev_test.c +++ b/tools/spi/spidev_test.c @@ -13,6 +13,7 @@ #include <stdio.h> #include <stdlib.h> #include <string.h> +#include <errno.h> #include <getopt.h> #include <fcntl.h> #include <time.h> @@ -26,7 +27,11 @@ static void pabort(const char *s) { - perror(s); + if (errno != 0) + perror(s); + else + printf("%s\n", s); + abort(); } |