summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTanmay Bhushan <007047221b@gmail.com>2022-12-30 15:18:58 +0100
committerTheodore Ts'o <tytso@mit.edu>2023-02-18 22:57:25 -0500
commit08abd0466ec9113908e674d042ec2a36dfc2875c (patch)
treebc446a3e406cce5405f0b490f43e270c70909ff7
parent240930fb7e6b52229bdee5b1423bfeab0002fed2 (diff)
ext4: remove dead code in updating backup sb
ext4_update_backup_sb checks for err having some value after unlocking buffer. But err has not been updated till that point in any code which will lead execution of the code in question. Signed-off-by: Tanmay Bhushan <007047221b@gmail.com> Reviewed-by: Jan Kara <jack@suse.cz> Link: https://lore.kernel.org/r/20221230141858.3828-1-007047221b@gmail.com Signed-off-by: Theodore Ts'o <tytso@mit.edu>
-rw-r--r--fs/ext4/ioctl.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
index 8067ccda34e4..2e8c34036313 100644
--- a/fs/ext4/ioctl.c
+++ b/fs/ext4/ioctl.c
@@ -155,9 +155,6 @@ static int ext4_update_backup_sb(struct super_block *sb,
set_buffer_uptodate(bh);
unlock_buffer(bh);
- if (err)
- goto out_bh;
-
if (handle) {
err = ext4_handle_dirty_metadata(handle, NULL, bh);
if (err)