From 17586188276980ff10d1244a35aeb31ae199705e Mon Sep 17 00:00:00 2001 From: "Naveen N. Rao" Date: Sun, 23 Apr 2017 22:53:43 +0530 Subject: kallsyms: Use bounded strnchr() when parsing string When parsing for the format, we use strchr() to look for the separator, when we know that the module name can't be longer than MODULE_NAME_LEN. Enforce the same using strnchr(). Signed-off-by: Naveen N. Rao Reviewed-by: Masami Hiramatsu Signed-off-by: Jessica Yu --- kernel/module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'kernel/module.c') diff --git a/kernel/module.c b/kernel/module.c index 7eba6dea4f41..d3bd56ed3541 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -4017,7 +4017,7 @@ unsigned long module_kallsyms_lookup_name(const char *name) /* Don't lock: we're in enough trouble already. */ preempt_disable(); - if ((colon = strchr(name, ':')) != NULL) { + if ((colon = strnchr(name, MODULE_NAME_LEN, ':')) != NULL) { if ((mod = find_module_all(name, colon - name, false)) != NULL) ret = mod_find_symname(mod, colon+1); } else { -- cgit v1.2.3-58-ga151