summaryrefslogtreecommitdiff
path: root/fs
diff options
context:
space:
mode:
authorJan Kara <jack@suse.cz>2023-10-04 11:37:57 +0200
committerChristian Brauner <brauner@kernel.org>2023-10-28 13:29:22 +0200
commitb3856da7906257a80a764d3dfc6b25e876a4403c (patch)
tree2203747a24ef4ad44af4f0d88dee972908c40882 /fs
parente340dd63f6a11402424b3d77e51149bce8fcba7d (diff)
bcache: Fixup error handling in register_cache()
Coverity has noticed that the printing of error message in register_cache() uses already freed bdev_handle to get to bdev. In fact the problem has been there even before commit "bcache: Convert to bdev_open_by_path()" just a bit more subtle one - cache object itself could have been freed by the time we looked at ca->bdev and we don't hold any reference to bdev either so even that could in principle go away (due to device unplug or similar). Fix all these problems by printing the error message before closing the bdev. Fixes: dc893f51d24a ("bcache: Convert to bdev_open_by_path()") Signed-off-by: Jan Kara <jack@suse.cz> Link: https://lore.kernel.org/r/20231004093757.11560-1-jack@suse.cz Asked-by: Coly Li <colyli@suse.de> Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'fs')
0 files changed, 0 insertions, 0 deletions