diff options
author | KP Singh <kpsingh@google.com> | 2020-06-22 00:21:35 +0200 |
---|---|---|
committer | James Morris <jmorris@namei.org> | 2020-06-23 16:39:23 -0700 |
commit | 23e390cdbe6f85827a43d38f9288dcd3066fa376 (patch) | |
tree | a08d76e08595224eee8ae4e44bfd238200ee3002 /fs/nfs/dir.c | |
parent | 4bc799dcb67066e0531004d5bdbe755bb02b5488 (diff) |
security: Fix hook iteration and default value for inode_copy_up_xattr
inode_copy_up_xattr returns 0 to indicate the acceptance of the xattr
and 1 to reject it. If the LSM does not know about the xattr, it's
expected to return -EOPNOTSUPP, which is the correct default value for
this hook. BPF LSM, currently, uses 0 as the default value and thereby
falsely allows all overlay fs xattributes to be copied up.
The iteration logic is also updated from the "bail-on-fail"
call_int_hook to continue on the non-decisive -EOPNOTSUPP and bail out
on other values.
Fixes: 98e828a0650f ("security: Refactor declaration of LSM hooks")
Signed-off-by: KP Singh <kpsingh@google.com>
Signed-off-by: James Morris <jmorris@namei.org>
Diffstat (limited to 'fs/nfs/dir.c')
0 files changed, 0 insertions, 0 deletions