diff options
author | Lukas Schauer <lukas@schauer.dev> | 2023-12-01 11:11:28 +0100 |
---|---|---|
committer | Christian Brauner <brauner@kernel.org> | 2023-12-12 14:24:54 +0100 |
commit | e95aada4cb93d42e25c30a0ef9eb2923d9711d4a (patch) | |
tree | 5c8f7f49d6d6ce84d88d4f6da4996ab582369356 /fs/inode.c | |
parent | 055ca83559912f2cfd91c9441427bac4caf3c74e (diff) |
pipe: wakeup wr_wait after setting max_usage
Commit c73be61cede5 ("pipe: Add general notification queue support") a
regression was introduced that would lock up resized pipes under certain
conditions. See the reproducer in [1].
The commit resizing the pipe ring size was moved to a different
function, doing that moved the wakeup for pipe->wr_wait before actually
raising pipe->max_usage. If a pipe was full before the resize occured it
would result in the wakeup never actually triggering pipe_write.
Set @max_usage and @nr_accounted before waking writers if this isn't a
watch queue.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=212295 [1]
Link: https://lore.kernel.org/r/20231201-orchideen-modewelt-e009de4562c6@brauner
Fixes: c73be61cede5 ("pipe: Add general notification queue support")
Reviewed-by: David Howells <dhowells@redhat.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Lukas Schauer <lukas@schauer.dev>
[Christian Brauner <brauner@kernel.org>: rewrite to account for watch queues]
Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'fs/inode.c')
0 files changed, 0 insertions, 0 deletions