diff options
| author | Luo Yifan <luoyifan@cmss.chinamobile.com> | 2024-11-06 09:46:54 +0800 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2024-11-07 13:07:16 +0000 |
| commit | 63c1c87993e0e5bb11bced3d8224446a2bc62338 (patch) | |
| tree | 74e08cd27f9cd7f83472e208ec3af3fd29dfefdd | |
| parent | 8c21e40e1e481f7fef6e570089e317068b972c45 (diff) | |
ASoC: stm: Prevent potential division by zero in stm32_sai_mclk_round_rate()
This patch checks if div is less than or equal to zero (div <= 0). If
div is zero or negative, the function returns -EINVAL, ensuring the
division operation (*prate / div) is safe to perform.
Signed-off-by: Luo Yifan <luoyifan@cmss.chinamobile.com>
Link: https://patch.msgid.link/20241106014654.206860-1-luoyifan@cmss.chinamobile.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/stm/stm32_sai_sub.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c index 7bc4a96b7503..2570daa3e225 100644 --- a/sound/soc/stm/stm32_sai_sub.c +++ b/sound/soc/stm/stm32_sai_sub.c @@ -378,8 +378,8 @@ static long stm32_sai_mclk_round_rate(struct clk_hw *hw, unsigned long rate, int div; div = stm32_sai_get_clk_div(sai, *prate, rate); - if (div < 0) - return div; + if (div <= 0) + return -EINVAL; mclk->freq = *prate / div; |