From 081a8ae2a54e85ddd77db77d50b1a04b3c4731c9 Mon Sep 17 00:00:00 2001 From: Colin Ian King Date: Thu, 21 Feb 2019 07:53:20 -0800 Subject: xfs: fix uninitialized error variable A previous commit removed the initialization of variable 'error' to zero, and can cause a bogus error return. This occurs when error contains a non-zero garbage value and the call to xchk_should_terminate detects a pending fatal signal and checks for a zero error before setting it to -EAGAIN. Fix the issue by initializing error to zero. Fixes: b9454fe056bd ("xfs: clean up the inode cluster checking in the inobt scrub") Signed-off-by: Colin Ian King Reviewed-by: Darrick J. Wong Signed-off-by: Darrick J. Wong --- fs/xfs/scrub/ialloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'fs/xfs') diff --git a/fs/xfs/scrub/ialloc.c b/fs/xfs/scrub/ialloc.c index 2c9dad2b61b1..700114f79a7d 100644 --- a/fs/xfs/scrub/ialloc.c +++ b/fs/xfs/scrub/ialloc.c @@ -161,7 +161,7 @@ xchk_iallocbt_check_cluster_ifree( bool irec_free; bool ino_inuse; bool freemask_ok; - int error; + int error = 0; if (xchk_should_terminate(bs->sc, &error)) return error; -- cgit v1.2.3-58-ga151