From 63513f8574c5ef481cd6a85b8c71f6f40f7d7957 Mon Sep 17 00:00:00 2001 From: Christian Brauner Date: Mon, 27 Nov 2023 12:51:31 +0100 Subject: super: don't bother with WARN_ON_ONCE() We hold our own active reference and we've checked it above. Link: https://lore.kernel.org/r/20231127-vfs-super-massage-wait-v1-2-9ab277bfd01a@kernel.org Signed-off-by: Christian Brauner --- fs/super.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'fs/super.c') diff --git a/fs/super.c b/fs/super.c index 9cfe9c379c3f..1745cf7ea005 100644 --- a/fs/super.c +++ b/fs/super.c @@ -2067,10 +2067,7 @@ retry: /* Release s_umount to preserve sb_start_write -> s_umount ordering */ super_unlock_excl(sb); sb_wait_write(sb, SB_FREEZE_WRITE); - if (!super_lock_excl(sb)) { - WARN_ON_ONCE("Dying superblock while freezing!"); - return -EINVAL; - } + __super_lock_excl(sb); /* Now we go and block page faults... */ sb->s_writers.frozen = SB_FREEZE_PAGEFAULT; -- cgit v1.2.3-58-ga151