From 9f12cea96f47f98d612a0a0b84f950a0163731bf Mon Sep 17 00:00:00 2001 From: Mark Rutland Date: Mon, 26 Sep 2016 16:16:18 +0100 Subject: drivers/tty: Explicitly pass current to show_stack As noted in commit: 81539169f283329f ("x86/dumpstack: Remove NULL task pointer convention") ... having a NULL task parameter imply current leads to subtle bugs in stack walking code (so far seen on both 86 and arm64), makes callsites harder to read, and is unnecessary as all callers have access to current. As a step towards removing the problematic NULL-implies-current idiom entirely, have the sysrq code explicitly pass current to show_stack. Signed-off-by: Mark Rutland Cc: Ingo Molnar Cc: Jiri Slaby Cc: Josh Poimboeuf Cc: linux-kernel@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/tty/sysrq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/tty') diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c index 52bbd27e93ae..5b1e0edacb84 100644 --- a/drivers/tty/sysrq.c +++ b/drivers/tty/sysrq.c @@ -224,7 +224,7 @@ static void showacpu(void *dummy) spin_lock_irqsave(&show_lock, flags); pr_info("CPU%d:\n", smp_processor_id()); - show_stack(NULL, NULL); + show_stack(current, NULL); spin_unlock_irqrestore(&show_lock, flags); } -- cgit v1.2.3-58-ga151