From 10800fec619d56acd04b1de86b6c3473bb04c2a8 Mon Sep 17 00:00:00 2001 From: YueHaibing Date: Mon, 30 Dec 2019 16:47:31 +0800 Subject: PM / devfreq: imx8m-ddrc: Fix inconsistent IS_ERR and PTR_ERR Fix inconsistent IS_ERR and PTR_ERR in imx8m_ddrc_probe(). Detected using Coccinelle. Signed-off-by: YueHaibing Signed-off-by: Chanwoo Choi --- drivers/devfreq/imx8m-ddrc.c | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) (limited to 'drivers/devfreq') diff --git a/drivers/devfreq/imx8m-ddrc.c b/drivers/devfreq/imx8m-ddrc.c index 53df7923d893..bc82d3653bff 100644 --- a/drivers/devfreq/imx8m-ddrc.c +++ b/drivers/devfreq/imx8m-ddrc.c @@ -395,15 +395,27 @@ static int imx8m_ddrc_probe(struct platform_device *pdev) } priv->dram_core = devm_clk_get(dev, "core"); + if (IS_ERR(priv->dram_core)) { + ret = PTR_ERR(priv->dram_core); + dev_err(dev, "failed to fetch core clock: %d\n", ret); + return ret; + } priv->dram_pll = devm_clk_get(dev, "pll"); + if (IS_ERR(priv->dram_pll)) { + ret = PTR_ERR(priv->dram_pll); + dev_err(dev, "failed to fetch pll clock: %d\n", ret); + return ret; + } priv->dram_alt = devm_clk_get(dev, "alt"); + if (IS_ERR(priv->dram_alt)) { + ret = PTR_ERR(priv->dram_alt); + dev_err(dev, "failed to fetch alt clock: %d\n", ret); + return ret; + } priv->dram_apb = devm_clk_get(dev, "apb"); - if (IS_ERR(priv->dram_core) || - IS_ERR(priv->dram_pll) || - IS_ERR(priv->dram_alt) || - IS_ERR(priv->dram_apb)) { - ret = PTR_ERR(priv->devfreq); - dev_err(dev, "failed to fetch clocks: %d\n", ret); + if (IS_ERR(priv->dram_apb)) { + ret = PTR_ERR(priv->dram_apb); + dev_err(dev, "failed to fetch apb clock: %d\n", ret); return ret; } -- cgit v1.2.3-58-ga151