diff options
| author | David Woodhouse <dwmw@amazon.co.uk> | 2021-12-10 16:36:20 +0000 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2022-01-07 10:44:44 -0500 |
| commit | 2efd61a608b0039911924d2e5d7028eb37496e85 (patch) | |
| tree | 26f889c3710b9b263c0f2c748a6882ddc4e41971 /virt/kvm/mmu_lock.h | |
| parent | f3f26dae05e39f0f286f588669b54d49b61dcfb8 (diff) | |
KVM: Warn if mark_page_dirty() is called without an active vCPU
The various kvm_write_guest() and mark_page_dirty() functions must only
ever be called in the context of an active vCPU, because if dirty ring
tracking is enabled it may simply oops when kvm_get_running_vcpu()
returns NULL for the vcpu and then kvm_dirty_ring_get() dereferences it.
This oops was reported by "butt3rflyh4ck" <butterflyhuangxx@gmail.com> in
https://lore.kernel.org/kvm/CAFcO6XOmoS7EacN_n6v4Txk7xL7iqRa2gABg3F7E3Naf5uG94g@mail.gmail.com/
That actual bug will be fixed under separate cover but this warning
should help to prevent new ones from being added.
Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Message-Id: <20211210163625.2886-2-dwmw2@infradead.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'virt/kvm/mmu_lock.h')
0 files changed, 0 insertions, 0 deletions