diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2023-04-16 14:06:58 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2023-04-18 17:05:28 -0700 |
| commit | 8c9b6a88b7e2f33c656cd667a081bfd4dc8f5005 (patch) | |
| tree | 4472b64ceefb67bc6d4115d1af4bc7ebb7201741 /tools/objtool | |
| parent | 577e6a7fd50d519c201d20968b6a027a6563dc4c (diff) | |
x86: improve on the non-rep 'clear_user' function
The old version was oddly written to have the repeat count in multiple
registers. So instead of taking advantage of %rax being zero, it had
some sub-counts in it. All just for a "single word clearing" loop,
which isn't even efficient to begin with.
So get rid of those games, and just keep all the state in the same
registers we got it in (and that we should return things in). That not
only makes this act much more like 'rep stos' (which this function is
replacing), but makes it much easier to actually do the obvious loop
unrolling.
Also rename the function from the now nonsensical 'clear_user_original'
to what it now clearly is: 'rep_stos_alternative'.
End result: if we don't have a fast 'rep stosb', at least we can have a
fast fallback for it.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'tools/objtool')
| -rw-r--r-- | tools/objtool/check.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 44817bbe48fe..ac96c9939cd1 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -1284,7 +1284,7 @@ static const char *uaccess_safe_builtin[] = { "copy_mc_fragile_handle_tail", "copy_mc_enhanced_fast_string", "ftrace_likely_update", /* CONFIG_TRACE_BRANCH_PROFILING */ - "clear_user_original", + "rep_stos_alternative", "copy_user_generic_unrolled", "__copy_user_nocache", NULL |