diff options
| author | Quentin Perret <qperret@google.com> | 2020-12-01 16:52:22 +0000 |
|---|---|---|
| committer | Masahiro Yamada <masahiroy@kernel.org> | 2020-12-21 13:57:08 +0900 |
| commit | b9ed847b5ae69e0f2e685f9d53e2dd94c0db751e (patch) | |
| tree | f92d7e36434405ba16cec571ff500b3bdf0f03b9 /scripts/mod | |
| parent | c7299d98c00afa81c65d9fa13a18ea923f3281ff (diff) | |
modpost: turn static exports into error
Using EXPORT_SYMBOL*() on static functions is fundamentally wrong.
Modpost currently reports that as a warning, but clearly this is not a
pattern we should allow, and all in-tree occurences should have been
fixed by now. So, promote the warn() message to error() to make sure
this never happens again.
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Matthias Maennich <maennich@google.com>
Signed-off-by: Quentin Perret <qperret@google.com>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'scripts/mod')
| -rw-r--r-- | scripts/mod/modpost.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index a750596d5cc2..d6c81657d695 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -2648,9 +2648,9 @@ int main(int argc, char **argv) for (s = symbolhash[n]; s; s = s->next) { if (s->is_static) - warn("\"%s\" [%s] is a static %s\n", - s->name, s->module->name, - export_str(s->export)); + error("\"%s\" [%s] is a static %s\n", + s->name, s->module->name, + export_str(s->export)); } } |