diff options
author | David Howells <dhowells@redhat.com> | 2012-10-04 14:21:23 +0100 |
---|---|---|
committer | Rusty Russell <rusty@rustcorp.com.au> | 2012-10-10 20:06:39 +1030 |
commit | dbadc17683e6c673a69b236c0f041b931cc55c42 (patch) | |
tree | ec29aabfa428ca2c06caba94595b8c5d51a687e7 /net | |
parent | 2f1c4fef103ef914e266588af263fb42b502b347 (diff) |
X.509: Fix indefinite length element skip error handling
asn1_find_indefinite_length() returns an error indicator of -1, which the
caller asn1_ber_decoder() places in a size_t (which is usually unsigned) and
then checks to see whether it is less than 0 (which it can't be). This can
lead to the following warning:
lib/asn1_decoder.c:320 asn1_ber_decoder()
warn: unsigned 'len' is never less than zero.
Instead, asn1_find_indefinite_length() update the caller's idea of the data
cursor and length separately from returning the error code.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions