diff options
| author | Patrick McHardy <kaber@trash.net> | 2008-01-23 20:36:30 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2008-01-28 15:11:23 -0800 |
| commit | 53b2bf3f8a652c9c8e86831f94ae2c5767ea54d7 (patch) | |
| tree | eba61efed08a932766a32b0b6a60e766f8b44bcb /net/sched/act_nat.c | |
| parent | 6fa8c0144b770dac941cf2c15053b6e24f046c8a (diff) | |
[NET_SCHED]: Use nla_policy for attribute validation in actions
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/act_nat.c')
| -rw-r--r-- | net/sched/act_nat.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/net/sched/act_nat.c b/net/sched/act_nat.c index 5a512d4dc37c..0a3c8339767a 100644 --- a/net/sched/act_nat.c +++ b/net/sched/act_nat.c @@ -40,6 +40,10 @@ static struct tcf_hashinfo nat_hash_info = { .lock = &nat_lock, }; +static const struct nla_policy nat_policy[TCA_NAT_MAX + 1] = { + [TCA_NAT_PARMS] = { .len = sizeof(struct tc_nat) }, +}; + static int tcf_nat_init(struct nlattr *nla, struct nlattr *est, struct tc_action *a, int ovr, int bind) { @@ -52,12 +56,11 @@ static int tcf_nat_init(struct nlattr *nla, struct nlattr *est, if (nla == NULL) return -EINVAL; - err = nla_parse_nested(tb, TCA_NAT_MAX, nla, NULL); + err = nla_parse_nested(tb, TCA_NAT_MAX, nla, nat_policy); if (err < 0) return err; - if (tb[TCA_NAT_PARMS] == NULL || - nla_len(tb[TCA_NAT_PARMS]) < sizeof(*parm)) + if (tb[TCA_NAT_PARMS] == NULL) return -EINVAL; parm = nla_data(tb[TCA_NAT_PARMS]); |