diff options
| author | Cong Wang <xiyou.wangcong@gmail.com> | 2018-08-29 10:15:35 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-08-31 22:50:15 -0700 |
| commit | f061b48c1787e6fece2190e27da6878f4f1796d0 (patch) | |
| tree | 11125d848a42e2d552f66d6c2b6806ac529c06e6 /net/sched/act_api.c | |
| parent | fd3c040b244b7aba6b18f7d12c87fd774b2257a8 (diff) | |
Revert "net: sched: act: add extack for lookup callback"
This reverts commit 331a9295de23 ("net: sched: act: add extack for lookup callback").
This extack is never used after 6 months... In fact, it can be just
set in the caller, right after ->lookup().
Cc: Alexander Aring <aring@mojatatu.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/act_api.c')
| -rw-r--r-- | net/sched/act_api.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/net/sched/act_api.c b/net/sched/act_api.c index db83dac1e7f4..398c752ff529 100644 --- a/net/sched/act_api.c +++ b/net/sched/act_api.c @@ -1067,12 +1067,14 @@ static struct tc_action *tcf_action_get_1(struct net *net, struct nlattr *nla, err = -EINVAL; ops = tc_lookup_action(tb[TCA_ACT_KIND]); if (!ops) { /* could happen in batch of actions */ - NL_SET_ERR_MSG(extack, "Specified TC action not found"); + NL_SET_ERR_MSG(extack, "Specified TC action kind not found"); goto err_out; } err = -ENOENT; - if (ops->lookup(net, &a, index, extack) == 0) + if (ops->lookup(net, &a, index) == 0) { + NL_SET_ERR_MSG(extack, "TC action with specified index not found"); goto err_mod; + } module_put(ops->owner); return a; |