diff options
author | David Howells <dhowells@redhat.com> | 2016-09-24 23:00:54 +0100 |
---|---|---|
committer | David Howells <dhowells@redhat.com> | 2016-09-24 23:49:46 +0100 |
commit | df0562a72dba13ab49c7dd7cb15170697b9848ee (patch) | |
tree | f486a25fd8590a0ea2b873ea4f0e31dee637ed7e /net/rxrpc/input.c | |
parent | dd7c1ee59a90ca8a75bce72c721851d5550f3c59 (diff) |
rxrpc: Delay the resend timer to allow for nsec->jiffies conv error
When determining the resend timer value, we have a value in nsec but the
timer is in jiffies which may be a million or more times more coarse.
nsecs_to_jiffies() rounds down - which means that the resend timeout
expressed as jiffies is very likely earlier than the one expressed as
nanoseconds from which it was derived.
The problem is that rxrpc_resend() gets triggered by the timer, but can't
then find anything to resend yet. It sets the timer again - but gets
kicked off immediately again and again until the nanosecond-based expiry
time is reached and we actually retransmit.
Fix this by adding 1 to the jiffies-based resend_at value to counteract the
rounding and make sure that the timer happens after the nanosecond-based
expiry is passed.
Alternatives would be to adjust the timestamp on the packets to align
with the jiffie scale or to switch back to using jiffie-timestamps.
Signed-off-by: David Howells <dhowells@redhat.com>
Diffstat (limited to 'net/rxrpc/input.c')
0 files changed, 0 insertions, 0 deletions