diff options
| author | Pietro Borrello <borrello@diag.uniroma1.it> | 2023-02-07 18:26:34 +0000 |
|---|---|---|
| committer | Paolo Abeni <pabeni@redhat.com> | 2023-02-09 10:37:26 +0100 |
| commit | f753a68980cf4b59a80fe677619da2b1804f526d (patch) | |
| tree | cd8b504872d3f8692f0e672e2427d8f455aa8a93 /net/rds | |
| parent | 646be03ec46cc736d78ca4db2e0b00fa84446d77 (diff) | |
rds: rds_rm_zerocopy_callback() use list_first_entry()
rds_rm_zerocopy_callback() uses list_entry() on the head of a list
causing a type confusion.
Use list_first_entry() to actually access the first element of the
rs_zcookie_queue list.
Fixes: 9426bbc6de99 ("rds: use list structure to track information for zerocopy completion notification")
Reviewed-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: Pietro Borrello <borrello@diag.uniroma1.it>
Link: https://lore.kernel.org/r/20230202-rds-zerocopy-v3-1-83b0df974f9a@diag.uniroma1.it
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'net/rds')
| -rw-r--r-- | net/rds/message.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/net/rds/message.c b/net/rds/message.c index b47e4f0a1639..c19c93561227 100644 --- a/net/rds/message.c +++ b/net/rds/message.c @@ -104,9 +104,9 @@ static void rds_rm_zerocopy_callback(struct rds_sock *rs, spin_lock_irqsave(&q->lock, flags); head = &q->zcookie_head; if (!list_empty(head)) { - info = list_entry(head, struct rds_msg_zcopy_info, - rs_zcookie_next); - if (info && rds_zcookie_add(info, cookie)) { + info = list_first_entry(head, struct rds_msg_zcopy_info, + rs_zcookie_next); + if (rds_zcookie_add(info, cookie)) { spin_unlock_irqrestore(&q->lock, flags); kfree(rds_info_from_znotifier(znotif)); /* caller invokes rds_wake_sk_sleep() */ |