diff options
author | David S. Miller <davem@davemloft.net> | 2020-05-15 12:30:13 -0700 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2020-05-15 12:30:13 -0700 |
commit | 93d43e58683efd958a0421b932a273df74e0e008 (patch) | |
tree | dd27101a3b5e26414458c2d0e9180a30d66025bd /net/ipv4/route.c | |
parent | ca1c933bcee9393d8a83c6be1093471e0c3b655d (diff) | |
parent | 729cd6436f359b6e618c2f14836d419f40444503 (diff) |
Merge branch 'mptcp-fix-MP_JOIN-failure-handling'
Paolo Abeni says:
====================
mptcp: fix MP_JOIN failure handling
Currently if we hit an MP_JOIN failure on the third ack, the child socket is
closed with reset, but the request socket is not deleted, causing weird
behaviors.
The main problem is that MPTCP's MP_JOIN code needs to plug it's own
'valid 3rd ack' checks and the current TCP callbacks do not allow that.
This series tries to address the above shortcoming introducing a new MPTCP
specific bit in a 'struct tcp_request_sock' hole, and leveraging that to allow
tcp_check_req releasing the request socket when needed.
The above allows cleaning-up a bit current MPTCP hooking in tcp_check_req().
An alternative solution, possibly cleaner but more invasive, would be
changing the 'bool *own_req' syn_recv_sock() argument into 'int *req_status'
and let MPTCP set it to 'REQ_DROP'.
v1 -> v2:
- be more conservative about drop_req initialization
RFC -> v1:
- move the drop_req bit inside tcp_request_sock (Eric)
====================
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/route.c')
0 files changed, 0 insertions, 0 deletions