diff options
| author | Diogo Jahchan Koike <djahchankoike@gmail.com> | 2024-08-26 10:45:46 -0300 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2024-08-27 12:47:38 -0700 |
| commit | 3d6a0c4f4552c8b08ba63b9da97c8255db4c6a56 (patch) | |
| tree | 2c521f9df2a95434b98d36585113503a9e341ca8 /net/ethtool | |
| parent | f8fdda9e4f988c210b1e4519a28ddbf7d29b0038 (diff) | |
net: fix unreleased lock in cable test
fix an unreleased lock in out_dev_put path by removing the (now)
unnecessary path.
Reported-by: syzbot+c641161e97237326ea74@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=c641161e97237326ea74
Fixes: 3688ff3077d3 ("net: ethtool: cable-test: Target the command to the requested PHY")
Signed-off-by: Diogo Jahchan Koike <djahchankoike@gmail.com>
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Link: https://patch.msgid.link/20240826134656.94892-1-djahchankoike@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/ethtool')
| -rw-r--r-- | net/ethtool/cabletest.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/net/ethtool/cabletest.c b/net/ethtool/cabletest.c index ff2fe3566ace..3a91b65c1f9a 100644 --- a/net/ethtool/cabletest.c +++ b/net/ethtool/cabletest.c @@ -77,7 +77,7 @@ int ethnl_act_cable_test(struct sk_buff *skb, struct genl_info *info) info->extack); if (IS_ERR_OR_NULL(phydev)) { ret = -EOPNOTSUPP; - goto out_dev_put; + goto out_rtnl; } ops = ethtool_phy_ops; @@ -99,7 +99,6 @@ int ethnl_act_cable_test(struct sk_buff *skb, struct genl_info *info) out_rtnl: rtnl_unlock(); -out_dev_put: ethnl_parse_header_dev_put(&req_info); return ret; } |