summaryrefslogtreecommitdiff
path: root/mm
diff options
context:
space:
mode:
authorYicong Yang <yangyicong@hisilicon.com>2020-11-21 22:17:19 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2020-11-22 10:48:22 -0800
commit488dac0c9237647e9b8f788b6a342595bfa40bda (patch)
tree23e382d2a5a9e47ba5045a23d57ec88df8e49030 /mm
parentbfe8cc1db02ab243c62780f17fc57f65bde0afe1 (diff)
libfs: fix error cast of negative value in simple_attr_write()
The attr->set() receive a value of u64, but simple_strtoll() is used for doing the conversion. It will lead to the error cast if user inputs a negative value. Use kstrtoull() instead of simple_strtoll() to convert a string got from the user to an unsigned value. The former will return '-EINVAL' if it gets a negetive value, but the latter can't handle the situation correctly. Make 'val' unsigned long long as what kstrtoull() takes, this will eliminate the compile warning on no 64-bit architectures. Fixes: f7b88631a897 ("fs/libfs.c: fix simple_attr_write() on 32bit machines") Signed-off-by: Yicong Yang <yangyicong@hisilicon.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Cc: Al Viro <viro@zeniv.linux.org.uk> Link: https://lkml.kernel.org/r/1605341356-11872-1-git-send-email-yangyicong@hisilicon.com Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm')
0 files changed, 0 insertions, 0 deletions