diff options
author | Daniel Jordan <daniel.m.jordan@oracle.com> | 2022-11-16 20:28:02 -0500 |
---|---|---|
committer | Herbert Xu <herbert@gondor.apana.org.au> | 2022-11-25 17:39:18 +0800 |
commit | 34c3a47d20ae55b3600fed733bf96eafe9c500d5 (patch) | |
tree | b561395c6d74757dcd6cef02edd3b3e8ca7e65f3 /mm/failslab.c | |
parent | 1aa33fc8d4032227253ceb736f47c52b859d9683 (diff) |
padata: Always leave BHs disabled when running ->parallel()
A deadlock can happen when an overloaded system runs ->parallel() in the
context of the current task:
padata_do_parallel
->parallel()
pcrypt_aead_enc/dec
padata_do_serial
spin_lock(&reorder->lock) // BHs still enabled
<interrupt>
...
__do_softirq
...
padata_do_serial
spin_lock(&reorder->lock)
It's a bug for BHs to be on in _do_serial as Steffen points out, so
ensure they're off in the "current task" case like they are in
padata_parallel_worker to avoid this situation.
Reported-by: syzbot+bc05445bc14148d51915@syzkaller.appspotmail.com
Fixes: 4611ce224688 ("padata: allocate work structures for parallel jobs from a pool")
Signed-off-by: Daniel Jordan <daniel.m.jordan@oracle.com>
Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'mm/failslab.c')
0 files changed, 0 insertions, 0 deletions